[Framework-Team] getting rid of plone.app.search

Discussion:

Nathan Van Gheem

2015-02-07 02:26:56 UTC

I'm working on fixing live search.

I was wondering if I could move plone.app.search into Products.CMFPlone.
The package only provides a view right now--seems a bit silly to be in it's
own package.

It would be part of this PLIP: https://dev.plone.org/ticket/13283

Makes more sense to do it package by package instead of one huge PR.

-Nathan

Timo Stollenwerk

2015-02-07 07:50:37 UTC

Permalink

Post by Nathan Van Gheem
It would be part of this PLIP: https://dev.plone.org/ticket/13283

Post by Nathan Van Gheem
Makes more sense to do it package by package instead of one huge PR.

+1

Timo

Roel Bruggink

2015-02-07 11:06:28 UTC

Permalink

+1!

Post by Nathan Van Gheem
I'm working on fixing live search.
I was wondering if I could move plone.app.search into Products.CMFPlone.
The package only provides a view right now--seems a bit silly to be in it's
own package.
It would be part of this PLIP: https://dev.plone.org/ticket/13283
Makes more sense to do it package by package instead of one huge PR.
-Nathan
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team

--
Roel Bruggink
https://www.fourdigits.nl/over-ons#roel-bruggink

Four Digits BV
https://www.fourdigits.nl tel: +31 26 4422700

Johannes Raggam

2015-02-07 11:13:57 UTC

Permalink

Post by Nathan Van Gheem
I'm working on fixing live search.

great!
that was also on my queue list, but i didn't make it due to time
constraints. alessandro pisa was working on this pattern at the mockup
training at the plone conference. do you continue on his work or start a
fresh one?
https://github.com/plone/mockup/tree/282-livesearch.js/mockup/patterns
https://github.com/plone/Products.CMFPlone/issues/287

just want to make sure, you've seen it.

regarding merging plone.app.search into cmfplone: +1, go for it!

cheers,
johannes

Post by Nathan Van Gheem
I was wondering if I could move plone.app.search into
Products.CMFPlone. The package only provides a view right now--seems a
bit silly to be in it's own package.
It would be part of this PLIP: https://dev.plone.org/ticket/13283
Makes more sense to do it package by package instead of one huge PR.
-Nathan
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team

Eric Steele

2015-02-07 15:45:46 UTC

Permalink

Big +1 from me!

For what it's worth, we replaced the stock livesearch with a select2
widget in one of our sites this week. Works beautifully.

Post by Nathan Van Gheem
I'm working on fixing live search.
I was wondering if I could move plone.app.search into
Products.CMFPlone.
The package only provides a view right now--seems a bit silly to be in it's
own package.
It would be part of this PLIP: https://dev.plone.org/ticket/13283
Makes more sense to do it package by package instead of one huge PR.
-Nathan
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team

Nathan Van Gheem

2015-02-07 15:52:28 UTC

Permalink

Post by Eric Steele
Big +1 from me!
For what it's worth, we replaced the stock livesearch with a select2
widget in one of our sites this week. Works beautifully.

Oh really. I'm actually getting a little bit of grief from select2--trying
to make it work like a livesearch widget. Can you share the code?

I'm having trouble with things like:

1) hitting enter always clicks first result instead of submitting to search
page
2) search text disappears when you focus out

So tips would be great.

Post by Eric Steele
I'm working on fixing live search.
I was wondering if I could move plone.app.search into Products.CMFPlone.
The package only provides a view right now--seems a bit silly to be in it's
own package.
It would be part of this PLIP: https://dev.plone.org/ticket/13283
Makes more sense to do it package by package instead of one huge PR.
-Nathan
------------------------------
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team

--
Nathan Van Gheem
Solutions Architect
Wildcard Corp

Nathan Van Gheem

2015-02-08 02:41:04 UTC

Permalink

Alright, plone.app.search is merged and I've implemented a new live search
pattern. I wasn't able to get select2 working the way I'd like though.

Post by Nathan Van Gheem

Post by Eric Steele
Big +1 from me!
For what it's worth, we replaced the stock livesearch with a select2
widget in one of our sites this week. Works beautifully.

Oh really. I'm actually getting a little bit of grief from select2--trying
to make it work like a livesearch widget. Can you share the code?
1) hitting enter always clicks first result instead of submitting to
search page
2) search text disappears when you focus out
So tips would be great.

--
Nathan Van Gheem
Solutions Architect
Wildcard Corp

Roel Bruggink

2015-02-08 11:53:14 UTC

Permalink

Nice! :D

Post by Nathan Van Gheem
Alright, plone.app.search is merged and I've implemented a new live search
pattern. I wasn't able to get select2 working the way I'd like though.

Post by Nathan Van Gheem

Post by Eric Steele
Big +1 from me!
For what it's worth, we replaced the stock livesearch with a select2
widget in one of our sites this week. Works beautifully.

Oh really. I'm actually getting a little bit of grief from
select2--trying to make it work like a livesearch widget. Can you share the
code?
1) hitting enter always clicks first result instead of submitting to
search page
2) search text disappears when you focus out
So tips would be great.

--
Nathan Van Gheem
Solutions Architect
Wildcard Corp

--
Nathan Van Gheem
Solutions Architect
Wildcard Corp
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team

--
Roel Bruggink
https://www.fourdigits.nl/over-ons#roel-bruggink

Four Digits BV
https://www.fourdigits.nl tel: +31 26 4422700