Discussion:
[Framework-Team] javascript versions
Jens W. Klein
2016-12-12 20:34:57 UTC
Permalink
Hi,

instead of posting this to community.plone.org I would like to have
opinions on this from the FWT.

I had a quick look on our javascript dep defined here:
https://github.com/plone/Products.CMFPlone/blob/master/Products/CMFPlone/static/bower.json

besides its bower and should turned into a package.json for npm ...:

the version in there are from javascript stoneage (2-3 years old).

I think we can update most of it w/o any problems.

Just JQuery might be a problem, we need to check this. But we shold
really go for latest.

w/o jquery and dependencies I think this could be save:

{
"name": "Products.CMFPlone",
"version": "5.0b2",
"description": "CMFPlone Javascript Bundle",
"dependencies": {
"ace-builds": "1.2.5",
"backbone": "1.3.3",
"backbone.paginator": "0.8.1",
"bootstrap": "3.3.7",
"console-polyfill": "0.2.3",
"dropzone": "4.3.0",
"es5-shim": "4.5.9",
"jqtree": "1.3.6",
"jquery": "1.11.3",
"jquery-form": "3.46.0",
"jquery.cookie": "1.4.1",
"jquery.recurrenceinput.js": "v1.5.2",
"logging": "",
"marked": "0.3.6",
"moment": "2.17.1",
"patternslib": "2.0.13",
"pickadate": "3.5.6",
"react": "15.4.1",
"requirejs-text": "2.0.15",
"select2": "4.0.3",
"selectivizr": "1.0.2",
"tinymce-builded": "4.3.12",
"requirejs": "",
"less": "2.1.2",
"r.js": "2.1.15"
},
"devDependencies": {
"expect": "0.3.1",
"sinonjs": "1.17.1"
},
"resolutions": {
"bootstrap": "3.3.7",
"jquery": "1.11.3",
"select2": "4.0.3",
"moment": "2.17.1"
}
}

What do you think?

Jens
--
Klein & Partner KG, member of BlueDynamics Alliance
Gil Forcada Codinachs
2016-12-13 08:07:54 UTC
Permalink
The only way I know we can check if it break things is running our test
suites 😃

So a pull request would be enough probably.

Do we have enough test coverage though?

Gil
Post by Jens W. Klein
Hi,
instead of posting this to community.plone.org I would like to have
opinions on this from the FWT.
https://github.com/plone/Products.CMFPlone/blob/master/
Products/CMFPlone/static/bower.json
the version in there are from javascript stoneage (2-3 years old).
I think we can update most of it w/o any problems.
Just JQuery might be a problem, we need to check this. But we shold
really go for latest.
{
"name": "Products.CMFPlone",
"version": "5.0b2",
"description": "CMFPlone Javascript Bundle",
"dependencies": {
"ace-builds": "1.2.5",
"backbone": "1.3.3",
"backbone.paginator": "0.8.1",
"bootstrap": "3.3.7",
"console-polyfill": "0.2.3",
"dropzone": "4.3.0",
"es5-shim": "4.5.9",
"jqtree": "1.3.6",
"jquery": "1.11.3",
"jquery-form": "3.46.0",
"jquery.cookie": "1.4.1",
"jquery.recurrenceinput.js": "v1.5.2",
"logging": "",
"marked": "0.3.6",
"moment": "2.17.1",
"patternslib": "2.0.13",
"pickadate": "3.5.6",
"react": "15.4.1",
"requirejs-text": "2.0.15",
"select2": "4.0.3",
"selectivizr": "1.0.2",
"tinymce-builded": "4.3.12",
"requirejs": "",
"less": "2.1.2",
"r.js": "2.1.15"
},
"devDependencies": {
"expect": "0.3.1",
"sinonjs": "1.17.1"
},
"resolutions": {
"bootstrap": "3.3.7",
"jquery": "1.11.3",
"select2": "4.0.3",
"moment": "2.17.1"
}
}
What do you think?
Jens
--
Klein & Partner KG, member of BlueDynamics Alliance
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
Eric Bréhault
2016-12-13 09:02:33 UTC
Permalink
Hi,

Everything which is Mockup related is properly tested.

I am not sure that's the case for the few legacy js thing we still have:
- ++resource++plone.app.discussion.javascripts/comments.js
- jquery.highlightsearchterms.js
- ++resource++plone.app.event/event.js

But that's not much.

Eric
Post by Gil Forcada Codinachs
The only way I know we can check if it break things is running our test
suites 😃
So a pull request would be enough probably.
Do we have enough test coverage though?
Gil
Hi,
Post by Jens W. Klein
instead of posting this to community.plone.org I would like to have
opinions on this from the FWT.
https://github.com/plone/Products.CMFPlone/blob/master/Produ
cts/CMFPlone/static/bower.json
the version in there are from javascript stoneage (2-3 years old).
I think we can update most of it w/o any problems.
Just JQuery might be a problem, we need to check this. But we shold
really go for latest.
{
"name": "Products.CMFPlone",
"version": "5.0b2",
"description": "CMFPlone Javascript Bundle",
"dependencies": {
"ace-builds": "1.2.5",
"backbone": "1.3.3",
"backbone.paginator": "0.8.1",
"bootstrap": "3.3.7",
"console-polyfill": "0.2.3",
"dropzone": "4.3.0",
"es5-shim": "4.5.9",
"jqtree": "1.3.6",
"jquery": "1.11.3",
"jquery-form": "3.46.0",
"jquery.cookie": "1.4.1",
"jquery.recurrenceinput.js": "v1.5.2",
"logging": "",
"marked": "0.3.6",
"moment": "2.17.1",
"patternslib": "2.0.13",
"pickadate": "3.5.6",
"react": "15.4.1",
"requirejs-text": "2.0.15",
"select2": "4.0.3",
"selectivizr": "1.0.2",
"tinymce-builded": "4.3.12",
"requirejs": "",
"less": "2.1.2",
"r.js": "2.1.15"
},
"devDependencies": {
"expect": "0.3.1",
"sinonjs": "1.17.1"
},
"resolutions": {
"bootstrap": "3.3.7",
"jquery": "1.11.3",
"select2": "4.0.3",
"moment": "2.17.1"
}
}
What do you think?
Jens
--
Klein & Partner KG, member of BlueDynamics Alliance
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
Loading...