Discussion:
[Framework-Team] social media meta tags plip
Nathan Van Gheem
2015-02-06 14:15:41 UTC
Permalink
Hi all,

I just added a real simple plip for some core functionality I think we
should have.

https://dev.plone.org/ticket/20256

Please consider this simple change to be included with Plone 5 yet.

All the code is done, pull requests are made, we just need review and the
review will only take 1 minute.
--
Nathan Van Gheem
Solutions Architect
Wildcard Corp
Eric Bréhault
2015-02-06 14:41:54 UTC
Permalink
Hi Nathan,

I agree it can be very useful.
Nevertheless, on the technical point of view, it could also be implemented
as an add-on.
Could you explain why you think it is better to put it in the core?

Eric
Post by Nathan Van Gheem
Hi all,
I just added a real simple plip for some core functionality I think we
should have.
https://dev.plone.org/ticket/20256
Please consider this simple change to be included with Plone 5 yet.
All the code is done, pull requests are made, we just need review and the
review will only take 1 minute.
--
Nathan Van Gheem
Solutions Architect
Wildcard Corp
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
Nathan Van Gheem
2015-02-06 14:46:54 UTC
Permalink
Every site we do gets this. Many things could be argued to not be in core
and be put in an addon. This is similar to dublin core meta tags that have
been in core for a long time and are mostly useless only this is actually
useful.
Post by Eric Bréhault
Hi Nathan,
I agree it can be very useful.
Nevertheless, on the technical point of view, it could also be implemented
as an add-on.
Could you explain why you think it is better to put it in the core?
Eric
Post by Nathan Van Gheem
Hi all,
I just added a real simple plip for some core functionality I think we
should have.
https://dev.plone.org/ticket/20256
Please consider this simple change to be included with Plone 5 yet.
All the code is done, pull requests are made, we just need review and the
review will only take 1 minute.
--
Nathan Van Gheem
Solutions Architect
Wildcard Corp
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
--
Nathan Van Gheem
Solutions Architect
Wildcard Corp
Eric Bréhault
2015-02-06 14:52:13 UTC
Permalink
Not every site needs it (Plone is used a lot to build intranets), but I
agree you are making a good point with the DublinCore similarity.
Post by Nathan Van Gheem
Every site we do gets this. Many things could be argued to not be in core
and be put in an addon. This is similar to dublin core meta tags that have
been in core for a long time and are mostly useless only this is actually
useful.
Post by Eric Bréhault
Hi Nathan,
I agree it can be very useful.
Nevertheless, on the technical point of view, it could also be
implemented as an add-on.
Could you explain why you think it is better to put it in the core?
Eric
Post by Nathan Van Gheem
Hi all,
I just added a real simple plip for some core functionality I think we
should have.
https://dev.plone.org/ticket/20256
Please consider this simple change to be included with Plone 5 yet.
All the code is done, pull requests are made, we just need review and
the review will only take 1 minute.
--
Nathan Van Gheem
Solutions Architect
Wildcard Corp
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
--
Nathan Van Gheem
Solutions Architect
Wildcard Corp
Franco Pellegrini
2015-02-06 16:27:47 UTC
Permalink
I like this functionality and I will help review it over the weekend.

I do think we will need to discuss if we can include it in 5.0 in next FWT
meeting

Thanks for the work Nathan
Post by Eric Bréhault
Not every site needs it (Plone is used a lot to build intranets), but I
agree you are making a good point with the DublinCore similarity.
Post by Nathan Van Gheem
Every site we do gets this. Many things could be argued to not be in core
and be put in an addon. This is similar to dublin core meta tags that have
been in core for a long time and are mostly useless only this is actually
useful.
Post by Eric Bréhault
Hi Nathan,
I agree it can be very useful.
Nevertheless, on the technical point of view, it could also be
implemented as an add-on.
Could you explain why you think it is better to put it in the core?
Eric
Post by Nathan Van Gheem
Hi all,
I just added a real simple plip for some core functionality I think we
should have.
https://dev.plone.org/ticket/20256
Please consider this simple change to be included with Plone 5 yet.
All the code is done, pull requests are made, we just need review and
the review will only take 1 minute.
--
Nathan Van Gheem
Solutions Architect
Wildcard Corp
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
--
Nathan Van Gheem
Solutions Architect
Wildcard Corp
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
Mikel Larreategi
2015-02-06 20:41:55 UTC
Permalink
I'm not in the FWT but there's at least one add on that provides this
functionality collective.opengraph and allows to be extended providing
adapters for each content type.

Mikel

--
Mikel Larreategi
CodeSyntax

+34 943821780
Post by Eric Bréhault
Hi Nathan,
I agree it can be very useful.
Nevertheless, on the technical point of view, it could also be implemented
as an add-on.
Could you explain why you think it is better to put it in the core?
Eric
Post by Nathan Van Gheem
Hi all,
I just added a real simple plip for some core functionality I think we
should have.
https://dev.plone.org/ticket/20256
Please consider this simple change to be included with Plone 5 yet.
All the code is done, pull requests are made, we just need review and the
review will only take 1 minute.
--
Nathan Van Gheem
Solutions Architect
Wildcard Corp
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
Roel Bruggink
2015-02-06 22:53:20 UTC
Permalink
Hi Nathan,

Thank you for the PLIP and the implementation.
We'll discuss this during the next FWT meeting.

Cheers!
Post by Mikel Larreategi
I'm not in the FWT but there's at least one add on that provides this
functionality collective.opengraph and allows to be extended providing
adapters for each content type.
Mikel
--
Mikel Larreategi
CodeSyntax
+34 943821780
Hi Nathan,
Post by Eric Bréhault
I agree it can be very useful.
Nevertheless, on the technical point of view, it could also be
implemented as an add-on.
Could you explain why you think it is better to put it in the core?
Eric
Post by Nathan Van Gheem
Hi all,
I just added a real simple plip for some core functionality I think we
should have.
https://dev.plone.org/ticket/20256
Please consider this simple change to be included with Plone 5 yet.
All the code is done, pull requests are made, we just need review and
the review will only take 1 minute.
--
Nathan Van Gheem
Solutions Architect
Wildcard Corp
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
_______________________________________________
Framework-Team mailing list
https://lists.plone.org/mailman/listinfo/plone-framework-team
--
Roel Bruggink
https://www.fourdigits.nl/over-ons#roel-bruggink

Four Digits BV
https://www.fourdigits.nl tel: +31 26 4422700
Loading...